Skip to content

fix: pass SCALER_BACKEND=keda to OpenShift E2E test step #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clubanderson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pass SCALER_BACKEND=keda to OpenShift E2E test step #979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci-e2e-openshift.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,8 @@ jobs:
LLMD_NAMESPACE_B: ${{ env.LLMD_NAMESPACE_B }}
GATEWAY_NAME: infra-inference-scheduling-inference-gateway-istio
DEPLOYMENT: ms-inference-scheduling-llm-d-modelservice-decode
# Must match the scaler backend used during infrastructure deployment
SCALER_BACKEND: keda
Comment on lines +1049 to +1050
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCALER_BACKEND is now hardcoded in multiple steps (infra deploy, Model B deploy, and this test step). To avoid future drift (e.g., changing the deploy backend but forgetting to update tests), consider defining SCALER_BACKEND: keda once at the job/workflow env: level and referencing it from each step, or reusing an existing ${{ env.SCALER_BACKEND }} value if you add one earlier.

Copilot uses AI. Check for mistakes.
# Pass WVA_RELEASE_NAME so test can filter for current run's resources
WVA_RELEASE_NAME: ${{ env.WVA_RELEASE_NAME }}
# Controller instance label must match what the controller was deployed with
Expand All @@ -1057,6 +1059,7 @@ jobs:
echo "Running consolidated E2E tests on OpenShift with configuration:"
echo " ENVIRONMENT: $ENVIRONMENT"
echo " USE_SIMULATOR: $USE_SIMULATOR"
echo " SCALER_BACKEND: $SCALER_BACKEND"
echo " SCALE_TO_ZERO_ENABLED: $SCALE_TO_ZERO_ENABLED"
echo " WVA_NAMESPACE: $WVA_NAMESPACE"
echo " MONITORING_NAMESPACE: $MONITORING_NAMESPACE"
Expand Down
Loading