flux: drop unnecessary timeout in Flux plugin #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There's some extraneous trailing whitespace in the `flux-spindle.c` Flux plugin sources. Fix the trailing whitespace.
Problem: The 300s timeout in the spindle flux plugin may cause large jobs experiencing slow startup to fail unnecessarily. Drop this timeout as unnecessary since the `shell.init` event is guaranteed to come at some point or the job will be timed out in some other manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spindle Flux plugin puts a 300s timeout while waiting for the
shell.initevent to be posted. This timeout could unnecessarily terminate a large job which is experiencing slow startup. Theshell.initevent is guaranteed to be posted for all jobs, and an overall timeout for hung jobs should be enforced elsewhere. Therefore, just drop the timeout in the spindle plugin.For more background see a similar issue in flux-coral2 fixed here: flux-framework/flux-coral2#433