-
Notifications
You must be signed in to change notification settings - Fork 31
SPANK plugin #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nchaimov
wants to merge
19
commits into
llnl:devel
Choose a base branch
from
ParaToolsInc:spank-plugin
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SPANK plugin #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Norbert Eicker <[email protected]>
- This saves them from premature killing by psmgmt
Co-authored-by: Norbert Eicker <[email protected]>
Co-authored-by: Norbert Eicker <[email protected]>
- Requires Slurm 23.11 or later or a backport of this function
run exactly once on every proc
610f2bc to
a72d3e0
Compare
Contributor
Author
|
Modified CI testing to use different container names for the srun/rshlaunch vs. SPANK jobs. While this didn't make any difference for GitHub Actions, using the same names prevented running these jobs simultaneously when running the CI locally through |
a72d3e0 to
cada056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Slurm SPANK plugin. It includes the commits from #52, for which the original description was:
The following additional changes are made:
parse_location_implwould segfault if a customgetenvwas used because memory would befreed which was not allocated throughmalloc.spindle_args_twas not initialized in the SPANK plugin.isBEProcfunction is adapted to also support selecting a single process per node to send the shutdown message.srun --spindleis used but the Spindle level isoff.RM=slurm-pluginKnown issue: Support for sessions in the SPANK plugin is not implemented and will be addressed in a future PR.