Modify 2D polygon clipping algorithm #1770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adayton1
reviewed
Jan 13, 2026
adayton1
reviewed
Jan 13, 2026
adayton1
reviewed
Jan 13, 2026
…formance of clipPolygonAddVertex.
…b.com:llnl/axom into bugfix/whitlock/polygon_clipping_corner_cases
rhornung67
approved these changes
Jan 13, 2026
adayton1
reviewed
Jan 13, 2026
|
|
||
| /// Compare two polygons with a tolerance. | ||
| template <typename PolygonType, typename T> | ||
| bool polygonsEqual(const PolygonType& p1, const PolygonType& p2, T tol) |
Member
There was a problem hiding this comment.
Would it make sense to add this as an isNearlyEqual method to the Polygon class like you did for the Point class?
adayton1
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1713.
Point::isNearlyEqual()method