[WIP] Fix Caliper cuda-activity-profile cupti profiling error
#1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
experiment
Comment on lines
+373
to
+384
|
|
||
| # Create a post-project include that runs after languages are enabled | ||
| after = join_path(self.stage.source_path, "force_cupti_after.cmake") | ||
| with open(after, "w") as f: | ||
| f.write( | ||
| "cmake_policy(SET CMP0074 NEW)\n" | ||
| "find_package(CUDAToolkit REQUIRED COMPONENTS cupti)\n" | ||
| ) | ||
|
|
||
| # Use CMAKE_PROJECT_INCLUDE (not TOP_LEVEL) so it runs after project() | ||
| options.append(f"-DCMAKE_PROJECT_INCLUDE={after}") | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This should be upstreamed to rajaperf cmakelists Nevermind, I got a similar issue with kripke, so this is a caliper issue
| { | ||
| "spec": f"cufft@{cuda_version}", | ||
| "prefix": f"/usr/tce/packages/cuda/cuda-{cuda_version}", | ||
| "prefix": f"/collab/usr/global/tools/nvidia/nvhpc/toss_4_x86_64_ib/nvhpc-25.1/Linux_x86_64/25.1/compilers/", |
Collaborator
Author
There was a problem hiding this comment.
This change does not work, maybe need to point at /collab/usr/global/tools/nvidia/nvhpc/toss_4_x86_64_ib/nvhpc-25.1/Linux_x86_64/25.1/math_libs/12.6/include/? or the issue is there are needed libraries in both dirs (nvhpc dir structure different from cuda).
Collaborator
Author
|
Not necessary for milestone since specific to cuda-activity-profile config, which we do not run in the tutorial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding/modifying a system (docs: Adding a System)
systems/system_name/system.pyfilesystems/all_hardware_descriptions/hardware_name/hardware_description.yamlwhich will appear in the docs catalogueAdding/modifying a benchmark (docs: Adding a Benchmark)
repo/benchmark_name/package.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.repo/benchmark_name/application.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.application.pyor inrepo/benchmark_name/application.pywill appear in the docs catalogueexperiments/benchmark_name/experiment.pyto define an experimentAdding/modifying core functionality, CI, or documentation:
.github/workflowsand.gitlab/testsunit tests (if needed)