-
Notifications
You must be signed in to change notification settings - Fork 42
remhos changes #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
remhos changes #1141
Conversation
pearce8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to think about GPU-aware MPI
| description="app version", | ||
| ) | ||
|
|
||
| variant( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nhanford Do we want a variant on this?
| if self.spec.satisfies("+gpu-aware-mpi"): | ||
| gam = "+gpu-aware-mpi" | ||
| self.add_package_spec( | ||
| self.name, [f"remhos{self.determine_version()} +metis {gam}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nhanford Do you think this is a reasonable way to pass on gpu aware requirements?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
+ Coverage 65.02% 65.14% +0.12%
===========================================
Files 44 44
Lines 3274 3274
Branches 261 261
===========================================
+ Hits 2129 2133 +4
+ Misses 1135 1131 -4
Partials 10 10 🚀 New features to boost your workflow:
|
Description
This PR:
experiment.py,application.pyandpackage.pyfor enabling gpu-aware-mpi in remhosAdding/modifying a benchmark (docs: Adding a Benchmark)
repo/benchmark_name/package.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.repo/benchmark_name/application.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.experiments/benchmark_name/experiment.pyto define an experimentThis PR depends on