Conversation
Collaborator
|
I added a |
thartland
reviewed
Mar 19, 2025
Collaborator
thartland
left a comment
thartland
left a comment
There was a problem hiding this comment.
I think the issue we discussed earlier has been resolved. Go ahead and test. Let me know when this is ready for review.
thartland
approved these changes
Mar 21, 2025
Collaborator
thartland
left a comment
thartland
left a comment
There was a problem hiding this comment.
This looks good to me. I previously tested the code prior to it being ready for review. Thanks!
cnpetra
approved these changes
Mar 21, 2025
Collaborator
cnpetra
left a comment
cnpetra
left a comment
There was a problem hiding this comment.
lgtm. I think we need tests and CI asap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR to address some issues listed in #712
More examples and CI will be added in another PR.