Add compact, sortable 'hashing' strategy for step ids/workspaces#465
Add compact, sortable 'hashing' strategy for step ids/workspaces#465
Conversation
…ts and substituted workspace tokens
…ots to a consistent character width for readability
doutriaux1
left a comment
doutriaux1
left a comment
There was a problem hiding this comment.
Looks good, only suggestion I have that can be ignored or added in a later PR would be to allow to control the hashing from within the yaml file either via key or env variable.
tests/integration/test_local.py
Outdated
| pytest.mark.integration,] | ||
|
|
||
|
|
||
| # @pytest.mark.parametrize( |
There was a problem hiding this comment.
Is this commented out on purpose?
tests/integration/test_local.py
Outdated
| Demonstrates how to display a tree of files / directories with the Tree renderable. | ||
| """ | ||
|
|
||
| # import os |
| ) | ||
|
|
||
| # Dummy test to force failure and show outputs | ||
| # assert completed_successfully == 'NOT A REAL STATUS' |
There was a problem hiding this comment.
have to do that if you want to see any of the printout's: pytest eats everything unless there's a failure. Really need some alternative switch in here that doesn't leave this kind of debris behind for a nicer test building/debugging workflow... But not on this pr, so will delete all these debug outputs
Yeah, that's gonna be a whole other pr. There's currently no where to put any of the study config in spec and I need to explore some alternatives to cluttering up the env/variables block with it as things like that + autoyes/rlimit/sleep have a different purpose from variables/labels/etc |
2 participants
Implements MEP 003's proposal for more human readable hashing of workspaces/step id's. Replaces default 'md5' algorithm for hashing step combinations in favor of sortable/human readable 'hash'. This is not a true 'hash', in that it needs all combos for a step to compute the pattern. Pattern is:
step_name_instance_<number>, where is a zero padded integer (zero based index) based on the number of used step combinations for a particular step. Zero padding ensures proper sorting on filesystems to improve usability.--hashwscli option to activate