Use batch executor for performance job clean up #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/flux so that the cleanup happens automatically if canceled/timed out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved solution from issue being addressed by #66.
The current issue is if a performance job is canceled in the GitLab CI or hits the GitLab job runner time limit, then the underlying flux or slurm job does not get canceled.
This PR address this by using the Jacamar batch executor instead of shell executor. This way Jacamar itself handles submitting the batch job and cleaning it up if it is cancelled/ hits timeout.
I have tested this for components/ non-components for the case where I canceled a queued job, a running job, and had the job hit the GitLab timeout. In all cases the flux/slurm job was cleaned up automatically.