Skip to content

Adding LEOS interface#340

Merged
jmikeowen merged 12 commits into
developfrom
feature/LEOS
Apr 28, 2025
Merged

Adding LEOS interface#340
jmikeowen merged 12 commits into
developfrom
feature/LEOS

Conversation

@jmikeowen
Copy link
Copy Markdown
Collaborator

@jmikeowen jmikeowen commented Apr 18, 2025 •
edited
Loading

Summary

  • This PR is a feature
  • It does the following:
    • Adding EquationOfState interface for using the Livermore Equation of State (LEOS) package
    • Requires access to the LEOS third-party library, which is only available at LLNL

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#133)
  • LLNLSpheral PR has passed all tests.

@jmikeowen jmikeowen marked this pull request as ready for review April 25, 2025 23:24
@jmikeowen jmikeowen requested review from ldowen and mdavis36 April 25, 2025 23:24
@jmikeowen
The LEOS atexit logic is no longer necessary (and didn't work anymore)
a91403e 
since I moved the LEOS::shutdown() command into the LEOS_bundle
destructor.  Good catch by Landon.
@jmikeowen jmikeowen merged commit f176791 into develop Apr 28, 2025
2 checks passed
@ldowen ldowen deleted the feature/LEOS branch February 20, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldowen ldowen ldowen approved these changes

@mdavis36 mdavis36 Awaiting requested review from mdavis36

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmikeowen @ldowen