Skip to content

Smoothing scale improvements#480

Open
brbass wants to merge 1 commit intollnl:developfrom
brbass:brody/smoothing-parameter
Open

Smoothing scale improvements#480
brbass wants to merge 1 commit intollnl:developfrom
brbass:brody/smoothing-parameter

Conversation

@brbass
Copy link
Copy Markdown
Contributor

@brbass brbass commented Mar 4, 2026

Summary

  • Adds a damping factor to the ideal-H iteration in both SPH and ASPH smoothing scales, which helps convergence for difficult initial distributions.
  • Adds a check in SpheralController that limits the initial neighbor count to a reasonable value before iterateIdealH begins.
  • Supports extra packages during initial H iteration and a flag to force Voronoi tessellation.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@mcfadden8 mcfadden8 mentioned this pull request Mar 25, 2026
3 tasks
print("Wrote viz file in %0.2f seconds" % (time.time() - start))
return

#--------------------------------------------------------------------------
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this method? It appears to be forcing H to be smaller if there are more points than would be implied if the kernelExtent was 1 and points are perfectly arranged. Not all kernels have kernelExtent=1 though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you start off with a large density gradient, for instance, a single point can encompass tens of thousands of others. This starts of iterateIdealH with a reasonable number of neighbors. If you don't think this function will be generally useful, we can remove it. If we want to keep it, then we should include the kernelExtent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants