Open
Conversation
# Conflicts: # src/PYB11/ArtificialViscosity/ArtificialViscosity.py # src/PYB11/ArtificialViscosity/ArtificialViscosityHandle.py # src/PYB11/ArtificialViscosity/FiniteVolumeViscosity.py # src/PYB11/ArtificialViscosity/LimitedMonaghanGingoldViscosity.py # src/PYB11/ArtificialViscosity/MonaghanGingoldViscosity.py # src/PYB11/ArtificialViscosity/TensorCRKSPHViscosity.py # src/PYB11/ArtificialViscosity/TensorMonaghanGingoldViscosity.py # src/PYB11/ArtificialViscosity/TensorSVPHViscosity.py
Contributor
Author
|
Just a note that this MR depends on #475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireConnectivity, requireGhostConnectivity, requireOverlapConnectivity, requireIntersectionConnectivityhave been replaced byrequireConnectivity{conn, ghost, overlap, intersection}requireVoronoiCellshas been replaced byrequireVolumes{explicit, implicit, voronoi}requireReproducingKernels, requireReproducingKernelInFinalize, requireReproducingKernelHessianhave been replaced byrequireReproducingKernels{explicit, implicit, hessian}Boundaryto codify this.GenerateRatioSphereaccessing the wrong element whenSPH = TrueTiming
Most of the code in this MR is focused on upgrading the volume calculation, but the reason behind it was to fix the inefficiency of ASPH (the True version, not the "classic" version). Here is an example of the timing for a 3D ASPH problem run on 100 procs for 200 cycles before and after these changes. The basic result: ASPH is improved from being prohibitively expensive before to being a reasonable option now.
ToDo :
RELEASE_NOTES.mdwith notable changes.