Skip to content

LSRKStep updates #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drreynolds wants to merge 12 commits into
base: feature/fes-yout-copy
Choose a base branch
from
Open

LSRKStep updates #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
40c1a68
General LSRKStep cleanup, including always using (tcur,ycur) as the c…
drreynolds Jan 16, 2026
df00866
Fixed merge issues
drreynolds Jan 16, 2026
ebc3fa3
Fixed additional merge issues
drreynolds Jan 16, 2026
92f2d94
Ran formatter
drreynolds Jan 16, 2026
eb5b287
Updated logging level 4 output files
drreynolds Jan 16, 2026
b473bd2
Updated logging level 5 output files
drreynolds Jan 16, 2026
0667085
Minor cleanup
drreynolds Jan 16, 2026
c713eca
Updated answers submodule commit
drreynolds Jan 16, 2026
86efcdb
Minor updates
drreynolds Jan 16, 2026
56e99f8
Merge ../fespr2-yout-copy into feature/fes-lsrk-cleanup
drreynolds Jan 16, 2026
5c29828
Updated logging output file
drreynolds Jan 16, 2026
5178c9a
Updated answers submodule commit
drreynolds Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
791 changes: 421 additions & 370 deletions src/arkode/arkode_lsrkstep.c
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/answers
Open in desktop
Submodule answers updated 3 files
+12 −12 linux-ubuntu20.04-x86_64/gcc-9.4.0/single/ark_analytic_ssprk.out
+60 −36 linux-ubuntu20.04-x86_64/gcc-9.4.0/single/test_logging_arkode_lsrkstep_lvl3_3.out
+34 −34 linux-ubuntu20.04-x86_64/gcc-9.4.0/single/test_logging_arkode_lsrkstep_lvl3_5.out
2 changes: 1 addition & 1 deletion test/unit_tests/logging/test_logging_arkode_lsrkstep_lvl4_2.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Start LSRKStep Logging test
[INFO][rank 0][lsrkStep_TakeStepSSPs2][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSPs2][begin-stages-list] stage = 8, tcur = 1.14611070421007e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs2][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSPs2][begin-stages-list] stage = 9, tcur = 1.28174438476562e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs2][begin-stages-list] stage = 9, tcur = 1.28174438476563e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs2][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSPs2][begin-stages-list] stage = 10, tcur = 1.28174438476563e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs2][end-stages-list] status = success
Expand Down
10 changes: 5 additions & 5 deletions test/unit_tests/logging/test_logging_arkode_lsrkstep_lvl4_3.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ Start LSRKStep Logging test
[INFO][rank 0][lsrkStep_TakeStepSSPs3][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSPs3][begin-compute-embedding]
[INFO][rank 0][lsrkStep_TakeStepSSPs3][end-compute-embedding] status = success
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.0011976776899388
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = inf
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 1.220703125e-06
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 20
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.32348889930549e-13
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 0
6.104125976562500e-08 6.104125976562493e-08 0.000000000000000e+00
[INFO][rank 0][ARKodeEvolve][begin-step-attempt] step = 3, tn = 6.1041259765625e-08, h = 1.220703125e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs3][begin-stages-list] stage = 0, tcur = 6.1041259765625e-08
Expand All @@ -81,11 +81,11 @@ Start LSRKStep Logging test
[INFO][rank 0][lsrkStep_TakeStepSSPs3][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSPs3][begin-compute-embedding]
[INFO][rank 0][lsrkStep_TakeStepSSPs3][end-compute-embedding] status = success
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.00221586141183015
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.00222529072291584
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 2.44140625e-05
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 20
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.67186954059802e-10
1.281744384765625e-06 1.281744384764923e-06 0.000000000000000e+00
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.65070663502083e-10
1.281744384765625e-06 1.281744384764923e-06 2.117582368135751e-22
---------------------------------------------------------------------
Current time = 1.28174438476563e-06
Steps = 3
Expand Down
10 changes: 5 additions & 5 deletions test/unit_tests/logging/test_logging_arkode_lsrkstep_lvl4_5.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ Start LSRKStep Logging test
[INFO][rank 0][lsrkStep_TakeStepSSP104][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSP104][begin-stages-list] stage = 10, tcur = 6.103515625e-12
[INFO][rank 0][lsrkStep_TakeStepSSP104][end-stages-list] status = success
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = inf
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 1.14486680447989e-07
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 6.103515625e-08
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 10000
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 0
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 8.07793566946316e-18
6.103515625000001e-12 6.103515625000001e-12 8.077935669463161e-28
[INFO][rank 0][ARKodeEvolve][begin-step-attempt] step = 2, tn = 6.103515625e-12, h = 6.103515625e-08
[INFO][rank 0][lsrkStep_TakeStepSSP104][begin-stages-list] stage = 0, tcur = 6.103515625e-12
Expand Down Expand Up @@ -81,11 +81,11 @@ Start LSRKStep Logging test
[INFO][rank 0][lsrkStep_TakeStepSSP104][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSP104][begin-stages-list] stage = 10, tcur = 1.28174438476563e-06
[INFO][rank 0][lsrkStep_TakeStepSSP104][end-stages-list] status = success
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.000715650921738838
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.000676820854209895
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 2.44140625e-05
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 20
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 8.46516223087607e-12
1.281744384765625e-06 1.281744384764922e-06 6.352747104407253e-22
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.05814527885951e-11
1.281744384765625e-06 1.281744384764922e-06 8.470329472543003e-22
---------------------------------------------------------------------
Current time = 1.28174438476563e-06
Steps = 3
Expand Down
2 changes: 1 addition & 1 deletion test/unit_tests/logging/test_logging_arkode_lsrkstep_lvl5_2.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Start LSRKStep Logging test
[DEBUG][rank 0][lsrkStep_TakeStepSSPs2][stage RHS] F_8(:) =
9.999999999986863e-01
[INFO][rank 0][lsrkStep_TakeStepSSPs2][end-stages-list] status = success
[INFO][rank 0][lsrkStep_TakeStepSSPs2][begin-stages-list] stage = 9, tcur = 1.28174438476562e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs2][begin-stages-list] stage = 9, tcur = 1.28174438476563e-06
[DEBUG][rank 0][lsrkStep_TakeStepSSPs2][stage RHS] F_9(:) =
9.999999999983570e-01
[INFO][rank 0][lsrkStep_TakeStepSSPs2][end-stages-list] status = success
Expand Down
12 changes: 6 additions & 6 deletions test/unit_tests/logging/test_logging_arkode_lsrkstep_lvl5_3.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,12 @@ Start LSRKStep Logging test
6.104125976562493e-08
[INFO][rank 0][lsrkStep_TakeStepSSPs3][begin-compute-embedding]
[DEBUG][rank 0][lsrkStep_TakeStepSSPs3][embedded solution] y_embedded(:) =
6.104125976562494e-08
6.104125976562493e-08
[INFO][rank 0][lsrkStep_TakeStepSSPs3][end-compute-embedding] status = success
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.0011976776899388
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = inf
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 1.220703125e-06
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 20
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.32348889930549e-13
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 0
6.104125976562500e-08 6.104125976562493e-08 0.000000000000000e+00
[INFO][rank 0][ARKodeEvolve][begin-step-attempt] step = 3, tn = 6.1041259765625e-08, h = 1.220703125e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs3][begin-stages-list] stage = 0, tcur = 6.1041259765625e-08
Expand Down Expand Up @@ -153,11 +153,11 @@ Start LSRKStep Logging test
[DEBUG][rank 0][lsrkStep_TakeStepSSPs3][embedded solution] y_embedded(:) =
1.281744384764940e-06
[INFO][rank 0][lsrkStep_TakeStepSSPs3][end-compute-embedding] status = success
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.00221586141183015
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.00222529072291584
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 2.44140625e-05
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 20
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.67186954059802e-10
1.281744384765625e-06 1.281744384764923e-06 0.000000000000000e+00
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.65070663502083e-10
1.281744384765625e-06 1.281744384764923e-06 2.117582368135751e-22
---------------------------------------------------------------------
Current time = 1.28174438476563e-06
Steps = 3
Expand Down
10 changes: 5 additions & 5 deletions test/unit_tests/logging/test_logging_arkode_lsrkstep_lvl5_5.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ Start LSRKStep Logging test
6.103515625000001e-12
[DEBUG][rank 0][lsrkStep_TakeStepSSP104][embedded solution] y_embedded(:) =
6.103515625000001e-12
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = inf
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 1.14486680447989e-07
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 6.103515625e-08
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 10000
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 0
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 8.07793566946316e-18
6.103515625000001e-12 6.103515625000001e-12 8.077935669463161e-28
[INFO][rank 0][ARKodeEvolve][begin-step-attempt] step = 2, tn = 6.103515625e-12, h = 6.103515625e-08
[INFO][rank 0][lsrkStep_TakeStepSSP104][begin-stages-list] stage = 0, tcur = 6.103515625e-12
Expand Down Expand Up @@ -159,11 +159,11 @@ Start LSRKStep Logging test
1.281744384764922e-06
[DEBUG][rank 0][lsrkStep_TakeStepSSP104][embedded solution] y_embedded(:) =
1.281744384764923e-06
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.000715650921738838
[DEBUG][rank 0][arkAdapt][new-step-before-bounds] h_acc = 0.000676820854209895
[DEBUG][rank 0][arkAdapt][new-step-after-max-min-bounds] h_acc = 2.44140625e-05
[DEBUG][rank 0][arkAdapt][new-step-eta] eta = 20
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 8.46516223087607e-12
1.281744384765625e-06 1.281744384764922e-06 6.352747104407253e-22
[INFO][rank 0][ARKodeEvolve][end-step-attempt] status = success, dsm = 1.05814527885951e-11
1.281744384765625e-06 1.281744384764922e-06 8.470329472543003e-22
---------------------------------------------------------------------
Current time = 1.28174438476563e-06
Steps = 3
Expand Down