Consistently use ycur for user RHS routines
#817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes ARKODE calls to the user-supplied right-hand-side functions so that wherever possible, these RHS calls are provided the user-supplied solution vector that was passed to
ARKodeEvolve.The notable exceptions to this rule are:
However, for most ARKODE integrators is it now possible for users to consistently receive back their own state vector for RHS calls, allowing them to leverage auxiliary data stored therein (e.g., derived quantities or MPI communication buffers).