Support timezone picker on ga_session.visitStart#26
Open
henrymei wants to merge 1 commit intollooker:masterfrom
Open
Support timezone picker on ga_session.visitStart#26henrymei wants to merge 1 commit intollooker:masterfrom
henrymei wants to merge 1 commit intollooker:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently (in at least BigQuery), using
TIMESTAMP(${visitStartSeconds})will trigger a double cast when you pick a non-UTC timezone sincevisitStarttreats the datetime it receives fromvisitStartSecondsas a string. Adding an inline type-hint avoids this and gives the desired behavior.This is also pointed out in the LookML documentation (thanks Olivia from DCL for finding it!).
cc: @ernestoongaro (since you seem to be the most active maintainer 😅)