-
Notifications
You must be signed in to change notification settings - Fork 151
Prepare for sbt-ci-release usage #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 63 63
Lines 511 511
Branches 34 34
=======================================
Hits 438 438
Misses 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Developer( | ||
"lloydmeta", | ||
"Lloyd Chan", | ||
"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is the contact email field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Overall I think it should be a nice change. I do have a few questions (very noob ones too, since I've not used this plugin or GH action!):
- Is there a way to preview whether this works or not and the artefacts it publishes ?
- Does this mean that we end up publishing 1 version for everything ? e.g. if there is a change to an integration lib, we end up publishing new versions of macros and core?
crossScalaVersions := scalaVersionsAll, | ||
libraryDependencies ++= { | ||
if (useLocalVersion) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting.
This was added as part of adding support for Scala 3.
Does testing macro changes still work without this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are passed both locally and on CI. Is there any preconditions to verify this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was used to test changes and fixes to macros during development. My suspicion is it may not be needed anymore and I'm happy to remove it and add it back in if we find otherwise later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just removed the rest of configureWithLocal
and it looks like everything is works fine (I ran +clean
, +test
).
To be honest, I haven't used sbt-ci-release myself too, but as I see it's a kind of meta-plugin for several things like sbt-sonatype, sbt-dynver, and sbt-gpg. I'm using sbt-sonatype and sbt-gpg in https://github.com/limansky/beanpuree, and some other projects.
|
I think you can also use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Going to hold off on merging until I get a chance to re-read https://github.com/sbt/sbt-ci-release?tab=readme-ov-file#how-do-i-publish-cross-built-projects and set it up. Thanks !
Hi @lloydmeta ,
Finally, I've done some preparations for sbt-ci-release usage. I removed all version values, to make sbt-dynver work. This requires to set tag on the previous version properly.
Also it is needed to setup build variables, to make publish work. (see https://github.com/sbt/sbt-ci-release).