Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding python files for graphing and processing csv data. #38

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Adding python files for graphing and processing csv data. #38

wants to merge 12 commits into from

Conversation

andrewkallai
Copy link

No description provided.

@vercel Vercel
Copy link

vercel bot commented Aug 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llvm-ir-dataset-utils ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 0:55am

boomanaiden154
boomanaiden154 reviewed Aug 10, 2024
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like there's any script here to invoke this from the command line to actually run it? How do you envision this being used? Inside a Jupyter notebook?

If this is planned on being used through a CLI script, at least a simple one should probably land within this patch.

@andrewkallai
Adding changes to utlities to plot and process csv files. Adding init…
94b86ad 
…ial jupyter notebook file to display results.
boomanaiden154
boomanaiden154 reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, one final comment.

Also, please take a look at the failing CI jobs.

boomanaiden154
boomanaiden154 reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to read the Google Python style guide to see how good docstrings are written: https://google.github.io/styleguide/pyguide.html#38-comments-and-docstrings.

There are some reasonable examples in https://github.com/google/ml-compiler-opt/tree/main/compiler_opt/benchmark if you look through the individual python files.

boomanaiden154
boomanaiden154 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boomanaiden154 boomanaiden154 boomanaiden154 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkallai @boomanaiden154