[SV] Switch passes to ODS constructors, NFC (#9929)

Switch passes to ODS constructors

AI-assisted-by: Codex 5.3

Author: uenoku

include/circt/Dialect/SV/SVPasses.h

@@ -14,23 +14,13 @@
 #define CIRCT_DIALECT_SV_SVPASSES_H
 
 #include "mlir/Pass/Pass.h"
-#include "llvm/ADT/StringRef.h"
 
 namespace circt {
 namespace sv {
 
 #define GEN_PASS_DECL
 #include "circt/Dialect/SV/SVPasses.h.inc"
 
-std::unique_ptr<mlir::Pass> createPrettifyVerilogPass();
-std::unique_ptr<mlir::Pass> createHWCleanupPass(bool mergeAlwaysBlocks = true);
-std::unique_ptr<mlir::Pass> createHWStubExternalModulesPass();
-std::unique_ptr<mlir::Pass> createHWLegalizeModulesPass();
-std::unique_ptr<mlir::Pass> createSVTraceIVerilogPass();
-std::unique_ptr<mlir::Pass> createHWGeneratorCalloutPass();
-std::unique_ptr<mlir::Pass> createHWEliminateInOutPortsPass(
-    const HWEliminateInOutPortsOptions &options = {});
-std::unique_ptr<mlir::Pass> createHWExportModuleHierarchyPass();
 /// Generate the code for registering passes.
 #define GEN_PASS_REGISTRATION
 #include "circt/Dialect/SV/SVPasses.h.inc"

include/circt/Dialect/SV/SVPasses.td

@@ -29,7 +29,6 @@ def HWCleanup : Pass<"hw-cleanup", "hw::HWModuleOp"> {
            "true", "Allow always and always_ff blocks to be merged">
   ];
 
-  let constructor = "circt::sv::createHWCleanupPass()";
 }
 
 def HWLegalizeModules : Pass<"hw-legalize-modules", "hw::HWModuleOp"> {
@@ -42,7 +41,6 @@ def HWLegalizeModules : Pass<"hw-legalize-modules", "hw::HWModuleOp"> {
       constructs.
   }];
 
-  let constructor = "circt::sv::createHWLegalizeModulesPass()";
 }
 
 def PrettifyVerilog : Pass<"prettify-verilog", "hw::HWModuleOp"> {
@@ -55,7 +53,6 @@ def PrettifyVerilog : Pass<"prettify-verilog", "hw::HWModuleOp"> {
       it is self contained.
   }];
 
-  let constructor = "circt::sv::createPrettifyVerilogPass()";
 }
 
 def HWStubExternalModules : Pass<"hw-stub-external-modules",
@@ -66,7 +63,6 @@ def HWStubExternalModules : Pass<"hw-stub-external-modules",
       useful for linting to eliminate missing file errors.
   }];
 
-  let constructor = "circt::sv::createHWStubExternalModulesPass()";
   let dependentDialects = ["circt::sv::SVDialect"];
 }
 
@@ -76,8 +72,6 @@ def HWGeneratorCalloutPass : Pass<"hw-generator-callout", "ModuleOp"> {
     This pass calls an external program for all the hw.module.generated nodes,
     following the description in the hw.generator.schema node.
   }];
-  let constructor = "circt::sv::createHWGeneratorCalloutPass()";
-
   let options = [
     Option<"schemaName", "schema-name", "std::string",
                 "", "Name of the schema to process">,
@@ -95,7 +89,6 @@ def SVTraceIVerilog : Pass<"sv-trace-iverilog", "ModuleOp"> {
     tracing in an iverilog simulation.
   }];
 
-  let constructor = "circt::sv::createSVTraceIVerilogPass()";
   let dependentDialects = ["circt::sv::SVDialect"];
   let options = [
     Option<"topOnly", "top-only", "bool", "true",
@@ -116,7 +109,6 @@ def HWExportModuleHierarchy : Pass<"hw-export-module-hierarchy",
     sv.verbatim ops with the output_file attribute.
   }];
 
-  let constructor = "circt::sv::createHWExportModuleHierarchyPass()";
   let dependentDialects = ["circt::emit::EmitDialect", "circt::sv::SVDialect"];
 }
 
@@ -129,7 +121,6 @@ def HWEliminateInOutPorts : Pass<"hw-eliminate-inout-ports",
     input and output ports at the using module, and subsequently moving the
     inout read- and writes to the instantiation site.
   }];
-  let constructor = "circt::sv::createHWEliminateInOutPortsPass()";
   let dependentDialects = ["circt::sv::SVDialect"];
   let options = [
     Option<"readSuffix", "read-suffix", "std::string", "\"_rd\"",

lib/Dialect/SV/Transforms/GeneratorCallout.cpp

@@ -40,6 +40,7 @@ namespace {
 struct HWGeneratorCalloutPass
     : public circt::sv::impl::HWGeneratorCalloutPassBase<
           HWGeneratorCalloutPass> {
+  using Base::Base;
   void runOnOperation() override;
 
   void processGenerator(HWModuleGeneratedOp generatedModuleOp,
@@ -168,7 +169,3 @@ void HWGeneratorCalloutPass::processGenerator(
   extMod->setAttr("filenames", builder.getStringAttr(fileContent));
   generatedModuleOp.erase();
 }
-
-std::unique_ptr<Pass> circt::sv::createHWGeneratorCalloutPass() {
-  return std::make_unique<HWGeneratorCalloutPass>();
-}

lib/Dialect/SV/Transforms/HWCleanup.cpp

@@ -101,6 +101,7 @@ static void mergeRegions(Region *region1, Region *region2) {
 
 namespace {
 struct HWCleanupPass : public circt::sv::impl::HWCleanupBase<HWCleanupPass> {
+  using Base::Base;
   using sv::impl::HWCleanupBase<HWCleanupPass>::mergeAlwaysBlocks;
 
   void runOnOperation() override;
@@ -248,9 +249,3 @@ void HWCleanupPass::runOnProceduralRegion(Region &region) {
       runOnRegionsInOp(op);
   }
 }
-
-std::unique_ptr<Pass> circt::sv::createHWCleanupPass(bool mergeAlwaysBlocks) {
-  auto pass = std::make_unique<HWCleanupPass>();
-  pass->mergeAlwaysBlocks = mergeAlwaysBlocks;
-  return pass;
-}

lib/Dialect/SV/Transforms/HWEliminateInOutPorts.cpp

@@ -233,8 +233,3 @@ void HWEliminateInOutPortsPass::runOnOperation() {
     }
   }
 }
-
-std::unique_ptr<Pass> circt::sv::createHWEliminateInOutPortsPass(
-    const HWEliminateInOutPortsOptions &options) {
-  return std::make_unique<HWEliminateInOutPortsPass>(options);
-}

lib/Dialect/SV/Transforms/HWExportModuleHierarchy.cpp

@@ -143,11 +143,3 @@ void HWExportModuleHierarchyPass::runOnOperation() {
 
   markAllAnalysesPreserved();
 }
-
-//===----------------------------------------------------------------------===//
-// Pass Creation
-//===----------------------------------------------------------------------===//
-
-std::unique_ptr<mlir::Pass> sv::createHWExportModuleHierarchyPass() {
-  return std::make_unique<HWExportModuleHierarchyPass>();
-}

lib/Dialect/SV/Transforms/HWLegalizeModules.cpp

@@ -478,7 +478,3 @@ void HWLegalizeModulesPass::runOnOperation() {
   if (!anythingChanged)
     markAllAnalysesPreserved();
 }
-
-std::unique_ptr<Pass> circt::sv::createHWLegalizeModulesPass() {
-  return std::make_unique<HWLegalizeModulesPass>();
-}

lib/Dialect/SV/Transforms/HWStubExternalModules.cpp

@@ -61,7 +61,3 @@ void HWStubExternalModulesPass::runOnOperation() {
       module.erase();
     }
 }
-
-std::unique_ptr<Pass> circt::sv::createHWStubExternalModulesPass() {
-  return std::make_unique<HWStubExternalModulesPass>();
-}

lib/Dialect/SV/Transforms/PrettifyVerilog.cpp

@@ -578,7 +578,3 @@ void PrettifyVerilogPass::runOnOperation() {
   if (!anythingChanged)
     markAllAnalysesPreserved();
 }
-
-std::unique_ptr<Pass> circt::sv::createPrettifyVerilogPass() {
-  return std::make_unique<PrettifyVerilogPass>();
-}

lib/Dialect/SV/Transforms/SVTraceIVerilog.cpp

@@ -39,6 +39,7 @@ namespace {
 
 struct SVTraceIVerilogPass
     : public circt::sv::impl::SVTraceIVerilogBase<SVTraceIVerilogPass> {
+  using Base::Base;
   void runOnOperation() override;
 };
 
@@ -77,7 +78,3 @@ void SVTraceIVerilogPass::runOnOperation() {
     sv::VerbatimOp::create(builder, hwmod.getLoc(), ss.str());
   }
 }
-
-std::unique_ptr<Pass> circt::sv::createSVTraceIVerilogPass() {
-  return std::make_unique<SVTraceIVerilogPass>();
-}