Skip to content

[ExportVerilog] "$name is not allowed in Verilog output" error does not fail pass #4770

Open
@dtzSiFive

Description

@dtzSiFive

Encountered crafting test over here: #4589 (comment) .

Is currently reachable + executed as part of the verilog-errors.mlir test case:

hw.module.extern @parameter ()

=>

verilog-error.mlir:4:1: error: name "parameter" is not allowed in Verilog output
hw.module.extern @parameter ()
^
verilog-error.mlir:4:1: note: see current operation: 
"hw.module.extern"() ({
}) {argLocs = [], argNames = [], comment = "", function_type = () -> (), parameters = [], resultLocs = [], resultNames = [], sym_name = "parameter"} : () -> ()
// Generated by CIRCT 1.34.0g20230304_3ddf879
// external module parameter

As an aside, getting our error tests to check that pass/execution is not successful would be great, cc #4553 .

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions