[CIR][Transforms][Bugfix] Do not use-after-free in MergeCleanups.

llvm · Jan 9, 2024 · ffcc114 · ffcc114
1 parent 7cf3119
commit ffcc114
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/clang/lib/CIR/Dialect/Transforms/MergeCleanups.cpp b/clang/lib/CIR/Dialect/Transforms/MergeCleanups.cpp
@@ -84,15 +84,16 @@ struct MergeTrivialConditionalBranches : public OpRewritePattern<BrCondOp> {
   void rewrite(BrCondOp op, PatternRewriter &rewriter) const final {
     auto constOp = llvm::cast<ConstantOp>(op.getCond().getDefiningOp());
     bool cond = constOp.getValue().cast<cir::BoolAttr>().getValue();
+    auto *destTrue = op.getDestTrue(), *destFalse = op.getDestFalse();
     Block *block = op.getOperation()->getBlock();
 
     rewriter.eraseOp(op);
     if (cond) {
-      rewriter.mergeBlocks(op.getDestTrue(), block);
-      rewriter.eraseBlock(op.getDestFalse());
+      rewriter.mergeBlocks(destTrue, block);
+      rewriter.eraseBlock(destFalse);
     } else {
-      rewriter.mergeBlocks(op.getDestFalse(), block);
-      rewriter.eraseBlock(op.getDestTrue());
+      rewriter.mergeBlocks(destFalse, block);
+      rewriter.eraseBlock(destTrue);
     }
   }
 };