Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Implement array cookie ABI for AppleARM64 targets #1301

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

andykaylor
Copy link
Collaborator

This change introduces CIRGenCXXABI subclasses for ARM and AppleARM64 and implements ARM CXXABI handling for array cookies.

This change introduces CIRGenCXXABI subclasses for ARM and AppleARM64 and
implements ARM CXXABI handling for array cookies.
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits fixed

clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp Outdated Show resolved Hide resolved
clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp Outdated Show resolved Hide resolved
clang/test/CIR/CodeGen/applearm64-array-cookies.cpp Outdated Show resolved Hide resolved
@bcardosolopes bcardosolopes changed the title Implement array cookie ABI for AppleARM64 targets [CIR][CIRGen] Implement array cookie ABI for AppleARM64 targets Jan 31, 2025
Copy link

github-actions bot commented Feb 1, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@bcardosolopes bcardosolopes merged commit 7c22251 into llvm:main Feb 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants