[CIR][NFC] Replace CIR attr visitor base class with a type switch #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the CirAttrVisitor use to eliminate the base class and instead use an llvm::TypeSwitch in the derived class to visit CIR attributes.
|
This change is motivated by review feedback received when I tried to upstream the mlir-tblegen change for the visitor (llvm/llvm-project#126332). (And I just realized that means I also need to back out those changes in this branch.) |
Lancern
changed the title
bcardosolopes
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the CirAttrVisitor use to eliminate the base class and instead use an llvm::TypeSwitch in the derived class to visit CIR attributes.
No observable change is intended.