-
Notifications
You must be signed in to change notification settings - Fork 192
[CIR] Support vector<bool> lowering and elementwise vector operations #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bcardosolopes
merged 5 commits into
llvm:main
from
mahmood82:users/mahmood/support_and_vectors
Jan 29, 2026
Merged
[CIR] Support vector<bool> lowering and elementwise vector operations #2081
bcardosolopes
merged 5 commits into
llvm:main
from
mahmood82:users/mahmood/support_and_vectors
Jan 29, 2026
+201
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Jan 12, 2026
c254790 to
ffb00cd
Compare
ffb00cd to
64a4539
Compare
Extend CIR to support vector<bool> across the type system, codegen, and LLVM lowering. This adds elementwise lowering for vector logical operators, vector-to-bool conversions, vector conditional expressions, and proper bool-to-int lowering for both scalar and vector types in the DirectToLLVM path, replacing several NYI cases.
d77f8f3 to
405a0f3
Compare
bcardosolopes
approved these changes
Jan 29, 2026
Member
bcardosolopes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend CIR to support vector across the type system, codegen, and LLVM lowering. This adds elementwise lowering for vector logical operators, vector-to-bool conversions, vector conditional expressions, and proper bool-to-int lowering for both scalar and vector types in the DirectToLLVM path, replacing several NYI cases.