Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh-352) #363

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh-352) #363

merged 2 commits into from
Jan 4, 2024

Conversation

yugr
Copy link
Member

@yugr yugr commented Dec 22, 2023 •
edited
Loading

The error manifested in code like

int a[16];
int *const p = a;

void foo() {
  p[0];
}

It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think @gitoleg will fix it soon.

bcardosolopes
bcardosolopes approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tried to solve the conflict manually, let's see if it passes the tests before I merge

@bcardosolopes bcardosolopes merged commit 473c305 into llvm:main Jan 4, 2024
6 checks passed
@yugr yugr mentioned this pull request Jan 9, 2024
Closed
lanza pushed a commit that referenced this pull request Jan 29, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh…
095c2ae 
…-352) (#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
lanza pushed a commit that referenced this pull request Mar 23, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh…
2d067f4 
…-352) (#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (ll…
4e8f97d 
…vmgh-352) (llvm#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (ll…
c2e8f2a 
…vmgh-352) (llvm#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
lanza pushed a commit that referenced this pull request Apr 29, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh…
e146c1d 
…-352) (#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
lanza pushed a commit that referenced this pull request Apr 29, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh…
983f5bb 
…-352) (#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (ll…
3f59788 
…vmgh-352) (llvm#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
lanza pushed a commit that referenced this pull request Apr 29, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh…
be13b81 
…-352) (#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (ll…
edb6c66 
…vmgh-352) (llvm#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (ll…
acea016 
…vmgh-352) (llvm#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (ll…
395f2fc 
…vmgh-352) (llvm#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
lanza pushed a commit that referenced this pull request Nov 5, 2024
@yugr @bcardosolopes @lanza
[CIR][Lowering] Support lowering of cir.const with GlobalViewAttr (gh…
3cbde7e 
…-352) (#363)

The error manifested in code like
```
int a[16];
int *const p = a;

void foo() {
  p[0];
}
```
It's one the most frequent errors in current llvm-test-suite.

I've added the test to globals.cir which is currently XFAILed, I think
@gitoleg will fix it soon.

Co-authored-by: Bruno Cardoso Lopes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yugr @bcardosolopes