Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][Lowering][Bugfix] lower ScopeOp with return op #364

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[CIR][Lowering][Bugfix] lower ScopeOp with return op #364

merged 1 commit into from
Jan 4, 2024

Conversation

gitoleg
Copy link
Collaborator

@gitoleg gitoleg commented Dec 22, 2023

ScopeOp may end with ReturnOp instead of YieldOp, that is not expected now. This PR fix this.
The reduced example is:

int foo() {
    {
        return 0;
    }
}

This is quite frequent bug in llvm-test-suite

bcardosolopes
bcardosolopes approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit f575c43 into llvm:main Jan 4, 2024
6 checks passed
lanza pushed a commit that referenced this pull request Jan 29, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (#364)
8a92eb8 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
lanza pushed a commit that referenced this pull request Mar 23, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (#364)
3f00bd3 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (llvm#364)
f8c6adb 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (llvm#364)
93cdf96 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (#364)
dd86e5e 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (#364)
c0783de 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (llvm#364)
370db03 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (#364)
cb185ad 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (llvm#364)
fbcacb0 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (llvm#364)
2650bc4 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (llvm#364)
87de502 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
lanza pushed a commit that referenced this pull request Nov 5, 2024
@gitoleg @lanza
[CIR][Lowering][Bugfix] Lower ScopeOp with return op (#364)
2b77a53 
`ScopeOp` may end with `ReturnOp` instead of `YieldOp`, that is not
expected now. This PR fix this.
The reduced example is:
```
int foo() {
    {
        return 0;
    }
}
```
This is quite frequent bug in `llvm-test-suite`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitoleg @bcardosolopes