Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR] [CodeGen] Implement unary floating point builtins #383

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

philnik777
Copy link
Contributor

No description provided.

Copy link
Collaborator

@sitio-couto sitio-couto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philnik777 thanks for the contribution! I've added just a few minor suggestions.

clang/include/clang/CIR/Dialect/IR/CIROps.td Outdated Show resolved Hide resolved
clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp Outdated Show resolved Hide resolved
clang/test/CIR/CodeGen/builtin-floating-point.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@sitio-couto sitio-couto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philnik777 thanks! LGTM.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after few nits (and one remaining rebase conflict)

clang/include/clang/CIR/Dialect/IR/CIROps.td Outdated Show resolved Hide resolved
clang/include/clang/CIR/Dialect/IR/CIROps.td Show resolved Hide resolved
@bcardosolopes bcardosolopes merged commit e11f7db into llvm:main Jan 16, 2024
6 checks passed
@YazZz1k
Copy link
Contributor

YazZz1k commented Jan 23, 2024

Hello @philnik777. Are you going to implement lowering of this builtins soon? If not, I can work on it

@philnik777
Copy link
Contributor Author

Yes, I already have a patch locally. I'll upload it soon.

@YazZz1k
Copy link
Contributor

YazZz1k commented Jan 23, 2024

Ok, thank you

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants