-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR] [CodeGen] Implement unary floating point builtins #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philnik777 thanks for the contribution! I've added just a few minor suggestions.
5e7bd47
to
b9668c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philnik777 thanks! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after few nits (and one remaining rebase conflict)
b9668c2
to
fca5bc0
Compare
Hello @philnik777. Are you going to implement lowering of this builtins soon? If not, I can work on it |
Yes, I already have a patch locally. I'll upload it soon. |
Ok, thank you |
No description provided.