[CIR][LibOpt] Extend std::find optimization to all calls with raw pointers #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Jan 16, 2024
yugr
reviewed
Jan 17, 2024
lanza
force-pushed
the
main
branch
2 times, most recently
from
4e069c6 to
79d4dc7
Compare
This reverts commit d883a02.
This reverts commit ecde0fa75f5b55e28d3b0b449d3cb30fe1432328.
This is super verbose, but I'm leaving around the old style code here to make it clear that this behavior is implemented during lowering.
philnik777
force-pushed
the
extend_find_libopt
branch
from
089634d to
53900ca
Compare
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
…nters (#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
…nters (llvm#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
…nters (#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
…nters (#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
…nters (llvm#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
…nters (#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
…nters (llvm#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…nters (llvm#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…nters (llvm#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
…nters (#400) This also adds a missing check whether the pointer returned from `memchr` is null and changes the result to `last` in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a missing check whether the pointer returned from
memchris null and changes the result tolastin that case.