Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Handle initilization of arrays #431

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

YazZz1k
Copy link
Contributor

@YazZz1k YazZz1k commented Jan 30, 2024

No description provided.

@YazZz1k YazZz1k changed the title [CIR][CIRGen] Handle initilization of arrays [WIP] [CIR][CIRGen] Handle initilization of arrays Jan 30, 2024
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good, any unfinished work or just wanted some initial feedback? You can move this our of Draft state.

@YazZz1k
Copy link
Contributor Author

YazZz1k commented Jan 31, 2024

Thanks. This looks good, any unfinished work or just wanted some initial feedback? You can move this our of Draft state.

There is a minor issue. I will fix it soon

@YazZz1k YazZz1k changed the title [WIP] [CIR][CIRGen] Handle initilization of arrays [CIR][CIRGen] Handle initilization of arrays Jan 31, 2024
@YazZz1k YazZz1k marked this pull request as ready for review January 31, 2024 14:16
@YazZz1k
Copy link
Contributor Author

YazZz1k commented Jan 31, 2024

@bcardosolopes PR was moved to 'ready for review' state. The difference from the draft is in commit b3a8d6d

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit 5fa4171 into llvm:main Jan 31, 2024
6 checks passed
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants