Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][LowerToLLVM] Support pointer arithmetic for function types #594

Merged
merged 2 commits into from
May 9, 2024

Conversation

PragmaTwice
Copy link
Contributor

@PragmaTwice PragmaTwice commented May 9, 2024

Same as void pointers void *, we treat function pointer arithmetic as GEP i8, according to the original behavior of clang (godbolt).

It's a part of #579, since I would like to split it to two tasks:

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the first PR and for making it incremental, way to go.

@bcardosolopes bcardosolopes merged commit 33b67ca into llvm:main May 9, 2024
6 checks passed
bcardosolopes pushed a commit that referenced this pull request May 18, 2024
In this PR, we support for dereferencing void pointers as a GNU C
extension. This include two modification:
- In CIRGen, we support to build ReturnStmt with void return type.
- In LowerToLLVM, we support to lower CIR load with void result type to
LLVM.

It's a part of #579, since I would
like to split it to two tasks:
- support pointer arithmetic for function types (#594)
- **support to dereference void pointer (this PR)**
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
…m#594)

Same as void pointers `void *`, we treat function pointer arithmetic as
`GEP i8`, according to the original behavior of clang
([godbolt](https://godbolt.org/z/EMdvfdTe7)).
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
In this PR, we support for dereferencing void pointers as a GNU C
extension. This include two modification:
- In CIRGen, we support to build ReturnStmt with void return type.
- In LowerToLLVM, we support to lower CIR load with void result type to
LLVM.

It's a part of llvm#579, since I would
like to split it to two tasks:
- support pointer arithmetic for function types (llvm#594)
- **support to dereference void pointer (this PR)**
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
…m#594)

Same as void pointers `void *`, we treat function pointer arithmetic as
`GEP i8`, according to the original behavior of clang
([godbolt](https://godbolt.org/z/EMdvfdTe7)).
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
In this PR, we support for dereferencing void pointers as a GNU C
extension. This include two modification:
- In CIRGen, we support to build ReturnStmt with void return type.
- In LowerToLLVM, we support to lower CIR load with void result type to
LLVM.

It's a part of llvm#579, since I would
like to split it to two tasks:
- support pointer arithmetic for function types (llvm#594)
- **support to dereference void pointer (this PR)**
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
…m#594)

Same as void pointers `void *`, we treat function pointer arithmetic as
`GEP i8`, according to the original behavior of clang
([godbolt](https://godbolt.org/z/EMdvfdTe7)).
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
In this PR, we support for dereferencing void pointers as a GNU C
extension. This include two modification:
- In CIRGen, we support to build ReturnStmt with void return type.
- In LowerToLLVM, we support to lower CIR load with void result type to
LLVM.

It's a part of llvm#579, since I would
like to split it to two tasks:
- support pointer arithmetic for function types (llvm#594)
- **support to dereference void pointer (this PR)**
lanza pushed a commit that referenced this pull request Nov 5, 2024
Same as void pointers `void *`, we treat function pointer arithmetic as
`GEP i8`, according to the original behavior of clang
([godbolt](https://godbolt.org/z/EMdvfdTe7)).
lanza pushed a commit that referenced this pull request Nov 5, 2024
In this PR, we support for dereferencing void pointers as a GNU C
extension. This include two modification:
- In CIRGen, we support to build ReturnStmt with void return type.
- In LowerToLLVM, we support to lower CIR load with void result type to
LLVM.

It's a part of #579, since I would
like to split it to two tasks:
- support pointer arithmetic for function types (#594)
- **support to dereference void pointer (this PR)**
lanza pushed a commit that referenced this pull request Mar 18, 2025
Same as void pointers `void *`, we treat function pointer arithmetic as
`GEP i8`, according to the original behavior of clang
([godbolt](https://godbolt.org/z/EMdvfdTe7)).
lanza pushed a commit that referenced this pull request Mar 18, 2025
In this PR, we support for dereferencing void pointers as a GNU C
extension. This include two modification:
- In CIRGen, we support to build ReturnStmt with void return type.
- In LowerToLLVM, we support to lower CIR load with void result type to
LLVM.

It's a part of #579, since I would
like to split it to two tasks:
- support pointer arithmetic for function types (#594)
- **support to dereference void pointer (this PR)**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants