Skip to content

Move the produced temporary generated files to a unique temp folder #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anutosh491 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move the produced temporary generated files to a unique temp folder #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions projects/mlir-python-bindings-wasm/WasmCompilerLinkerLoaderCAPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#include "llvm/IR/LegacyPassManager.h"
#include "llvm/IR/Module.h"
#include "llvm/MC/TargetRegistry.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/Path.h"
#include "llvm/Support/TargetSelect.h"
#include "llvm/Target/TargetMachine.h"

Expand Down Expand Up @@ -93,11 +95,18 @@ MlirStringRef compileModule(MlirOperation module, MlirStringRef moduleName,
assert(optLevel >= 0 && optLevel <= 3 && "expected optLevel between 0 and 3");
targetMachine->setOptLevel(static_cast<llvm::CodeGenOptLevel>(optLevel));
llvmModule->setDataLayout(targetMachine->createDataLayout());
std::string moduleNameStr(unwrap(moduleName));
std::string objectFileName = moduleNameStr + ".o";

llvm::SmallString<256> TempDir;
std::error_code EC = llvm::sys::fs::createUniqueDirectory("wasm-module", TempDir);
if (EC)
llvm::report_fatal_error("Failed to create temporary directory: " + EC.message());

llvm::SmallString<256> objectFileName(TempDir);
llvm::sys::path::append(objectFileName, unwrap(moduleName));
objectFileName.append(".o");

std::error_code error;
llvm::raw_fd_ostream objectFileOutput(llvm::StringRef(objectFileName), error);
llvm::raw_fd_ostream objectFileOutput(objectFileName, error);

llvm::legacy::PassManager pm;
if (targetMachine->addPassesToEmitFile(pm, objectFileOutput, nullptr,
Expand All @@ -114,17 +123,20 @@ MlirStringRef compileModule(MlirOperation module, MlirStringRef moduleName,

void linkLoadModule(MlirStringRef objectFileName,
MlirStringRef binaryFileName) {
std::string objectFileNameStr(unwrap(objectFileName));
std::string binaryFileNameStr(unwrap(binaryFileName));
llvm::SmallString<256> ObjectFileName(unwrap(objectFileName));

llvm::SmallString<256> BinaryFileName(llvm::sys::path::parent_path(ObjectFileName));
llvm::sys::path::append(BinaryFileName, unwrap(binaryFileName));

std::vector<const char *> linkerArgs = {"wasm-ld",
"-shared",
"--import-memory",
"--experimental-pic",
"--stack-first",
"--allow-undefined",
objectFileNameStr.c_str(),
ObjectFileName.c_str(),
"-o",
binaryFileNameStr.c_str()};
BinaryFileName.c_str()};

const lld::DriverDef wasmDriver = {lld::Flavor::Wasm, &lld::wasm::link};
std::vector<lld::DriverDef> wasmDriverArgs;
Expand All @@ -136,7 +148,7 @@ void linkLoadModule(MlirStringRef objectFileName,
llvm::report_fatal_error("Failed to link incremental module");

void *loadedLibModule =
dlopen(binaryFileNameStr.c_str(), RTLD_NOW | RTLD_GLOBAL);
dlopen(BinaryFileName.c_str(), RTLD_NOW | RTLD_GLOBAL);
if (!loadedLibModule)
llvm::report_fatal_error("Failed to link incremental module");
}
Expand All @@ -145,6 +157,6 @@ void *getSymbolAddress(MlirStringRef name) {
std::string nameStr(unwrap(name));
void *sym = dlsym(RTLD_DEFAULT, nameStr.c_str());
if (!sym)
llvm::report_fatal_error("dlsym failed for symbol: ");
llvm::report_fatal_error("dlsym failed for symbol: " + nameStr);
return sym;
}