Skip to content

Commit 749c20b

Browse files
committed
[LIT] Add a test for lit.Test.toMetricValue. NFC
1 parent e5809f0 commit 749c20b

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

Diff for: llvm/utils/lit/tests/Inputs/test-data/dummy_format.py

+8-2
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,16 @@ def execute(self, test, lit_config):
2727
# Load additional metrics.
2828
for key, value_str in cfg.items("results"):
2929
value = eval(value_str)
30+
metric = lit.Test.toMetricValue(value)
3031
if isinstance(value, int):
31-
metric = lit.Test.IntMetricValue(value)
32+
assert isinstance(metric, lit.Test.IntMetricValue)
33+
assert metric.format() == lit.Test.IntMetricValue(value).format()
3234
elif isinstance(value, float):
33-
metric = lit.Test.RealMetricValue(value)
35+
assert isinstance(metric, lit.Test.RealMetricValue)
36+
assert metric.format() == lit.Test.RealMetricValue(value).format()
37+
elif isinstance(value, str):
38+
assert isinstance(metric, lit.Test.JSONMetricValue)
39+
assert metric.format() == lit.Test.JSONMetricValue(value).format()
3440
else:
3541
raise RuntimeError("unsupported result type")
3642
result.addMetric(key, metric)

Diff for: llvm/utils/lit/tests/Inputs/test-data/metrics.ini

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ result_output = Test passed.
44

55
[results]
66
value0 = 1
7-
value1 = 2.3456
7+
value1 = 2.3456
8+
value2 = "stringy"

Diff for: llvm/utils/lit/tests/test-data.py

+1
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@
99
# CHECK-NEXT: *** TEST 'test-data :: metrics.ini' RESULTS ***
1010
# CHECK-NEXT: value0: 1
1111
# CHECK-NEXT: value1: 2.3456
12+
# CHECK-NEXT: value2: "stringy"
1213
# CHECK-NEXT: ***

Diff for: llvm/utils/lit/tests/test-output.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
# CHECK-NEXT: "elapsed": {{[-+0-9.eE]+}},
1111
# CHECK-NEXT: "metrics": {
1212
# CHECK-NEXT: "value0": 1,
13-
# CHECK-NEXT: "value1": 2.3456
13+
# CHECK-NEXT: "value1": 2.3456,
14+
# CHECK-NEXT: "value2": "stringy"
1415
# CHECK-NEXT: }
1516
# CHECK-NEXT: "name": "test-data :: metrics.ini",
1617
# CHECK-NEXT: "output": "Test passed."

0 commit comments

Comments
 (0)