add todos

ergawy · ergawy · commit a505cf52410b · 2025-05-09T05:31:05.000-05:00
diff --git a/flang/lib/Optimizer/Transforms/SimplifyFIROperations.cpp b/flang/lib/Optimizer/Transforms/SimplifyFIROperations.cpp
@@ -186,6 +186,8 @@ class DoConcurrentConversion
             llvm::cast<mlir::SymbolRefAttr>(localizerSym);
         fir::LocalitySpecifierOp localizer = findLocalizer(loop, localizerName);
 
+        // TODO Should this be a heap allocation instead? For now, we allocate
+        // on the stack for each loop iteration.
         mlir::Value localAlloc =
             rewriter.create<fir::AllocaOp>(loop.getLoc(), localizer.getType());
 
@@ -210,6 +212,9 @@ class DoConcurrentConversion
         }
 
         rewriter.replaceAllUsesWith(localArg, localAlloc);
+
+        // TODO localizers with `init` and `dealloc` regions are not handled
+        // yet.
       }
 
       loop.getRegion().front().eraseArguments(loop.getNumInductionVars(),

Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,8 @@ class DoConcurrentConversion`
`186`	`186`	`llvm::cast<mlir::SymbolRefAttr>(localizerSym);`
`187`	`187`	`fir::LocalitySpecifierOp localizer = findLocalizer(loop, localizerName);`
`188`	`188`
	`189`	`+ // TODO Should this be a heap allocation instead? For now, we allocate`
	`190`	`+ // on the stack for each loop iteration.`
`189`	`191`	`mlir::Value localAlloc =`
`190`	`192`	`rewriter.create<fir::AllocaOp>(loop.getLoc(), localizer.getType());`
`191`	`193`
`@@ -210,6 +212,9 @@ class DoConcurrentConversion`
`210`	`212`	`}`
`211`	`213`
`212`	`214`	`rewriter.replaceAllUsesWith(localArg, localAlloc);`
	`215`	`+`
	`216`	+ // TODO localizers with `init` and `dealloc` regions are not handled
	`217`	`+ // yet.`
`213`	`218`	`}`
`214`	`219`
`215`	`220`	`loop.getRegion().front().eraseArguments(loop.getNumInductionVars(),`