[flang][runtime] REDUCE likely uses wrong callback signatures for COMPLEX VALUE

[jeanPerier]

I am removing fir.complex, and doing so, I realize that the REDUCE runtime implementation for COMPLEX is likely not correct for all targets since it uses std::complex values for the interface of the user defined function. The user function defined in Fortran is equivalent to C Complex.

This likely does not matter on aarch64 / x86-64, so I do not have a program demonstrating the issue functionally. On windows 32 bits, that would most likely cause issues.

llvm-project/flang/runtime/reduce.cpp

Line 528 in 00ab44e

ValueReductionOperation<CppTypeFor<TypeCategory::Complex, 4>> operation,

[llvmbot]

@llvm/issue-subscribers-flang-runtime

Author: None (jeanPerier)

I am removing fir.complex, and doing so, I realize that the REDUCE runtime implementation for COMPLEX is likely not correct for all targets since it uses std::complex values for the interface of the user defined function. The user function defined in Fortran is equivalent to C Complex.

This likely does not matter on aarch64 / x86-64, so I do not have a program demonstrating the issue functionally. On windows 32 bits, that would most likely cause issues.

llvm-project/flang/runtime/reduce.cpp

Line 528 in 00ab44e

ValueReductionOperation<CppTypeFor<TypeCategory::Complex, 4>> operation,

[llvmbot]

@llvm/issue-subscribers-bug

Author: None (jeanPerier)

I am removing fir.complex, and doing so, I realize that the REDUCE runtime implementation for COMPLEX is likely not correct for all targets since it uses std::complex values for the interface of the user defined function. The user function defined in Fortran is equivalent to C Complex.

This likely does not matter on aarch64 / x86-64, so I do not have a program demonstrating the issue functionally. On windows 32 bits, that would most likely cause issues.

llvm-project/flang/runtime/reduce.cpp

Line 528 in 00ab44e

ValueReductionOperation<CppTypeFor<TypeCategory::Complex, 4>> operation,