Issues found PVS studio static analyzer. LVCodeViewReader.cpp

[Seraphimt]

Main issue:
#169959
4. Potent UB: manipulation of invalid object. The PVS-Studio warning: V519 The 'FeaturesValue' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1190, 1192. LVCodeViewReader.cpp 1192

[llvmbot]

@llvm/issue-subscribers-debuginfo

Author: None (Seraphimt)

Details

Main issue: https://github.com//issues/169959 4. Potent UB: manipulation of invalid object. The PVS-Studio warning: V519 The 'FeaturesValue' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1190, 1192. LVCodeViewReader.cpp 1192

[CarlosAlbertoEnciso]

  SubtargetFeatures FeaturesValue;
  if (!Features) {
    consumeError(Features.takeError());
    FeaturesValue = SubtargetFeatures();
  }
  FeaturesValue = *Features;

I think it is a mistake. It is missing the else statement. It should be:

  SubtargetFeatures FeaturesValue;
  if (!Features) {
    consumeError(Features.takeError());
    FeaturesValue = SubtargetFeatures();
  } else {
    FeaturesValue = *Features;
  }