Issues found PVS studio static analyzer. DwarfDebug.cpp 485

[Seraphimt]

Main issue:
#169959
8. Excessive check or logic issue. The PVS-Studio warning: V590 Consider inspecting this expression. The expression is excessive or contains a misprint. DwarfDebug.cpp 485

[llvmbot]

@llvm/issue-subscribers-debuginfo

Author: None (Seraphimt)

Details

Main issue: https://github.com//issues/169959 8. Excessive check or logic issue. The PVS-Studio warning: V590 Consider inspecting this expression. The expression is excessive or contains a misprint. DwarfDebug.cpp 485

[OCHyams]

I think this is pointing to this code in DwarfDebug:

// Add the various names to the Dwarf accelerator table names.
void DwarfDebug::addSubprogramNames(
    const DwarfUnit &Unit,
    const DICompileUnit::DebugNameTableKind NameTableKind,
    const DISubprogram *SP, DIE &Die) {
  if (getAccelTableKind() != AccelTableKind::Apple &&
      NameTableKind != DICompileUnit::DebugNameTableKind::Apple &&
      NameTableKind == DICompileUnit::DebugNameTableKind::None)
    return;

The git history turns up 8af224d cc @felipepiovezan in case it's of interest to you.