clang ignores non-weak function definition

[zlojvavan]

please see and compare output of https://godbolt.org/z/bahPa15fx between gcc and clang (both from trunk)

for me clang doesn't override default tsan weak function definition __tsan_default_suppressions() with mine one, defined in header file

what is more puzzling on my ubuntu 23 I can use workaround, define __tsan_default_suppressions() not in some header file but in one of the source files and then it correctly uses that definition (as if STRONG_IN_HEADER wasn't defined in godbolt sample), but on godbolt I wasn't able to make it use my redefinition even with this workaround

[zlojvavan]

my ubuntu version (clang --version):

Ubuntu clang version 17.0.4 (++20231031093940+309d55140c46-1exp120231031093956.26)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

[Yvan-xy]

I removed the inline keyword, and it goes well in Clang. https://godbolt.org/z/qsWrYvscM
With the keyword inline, the linkage type of __tsan_default_suppressions is linkonce_odr

linkonce_odr, weak_odr

Some languages allow differing globals to be merged, such as two functions with different semantics. Other languages, such as C++, ensure that only equivalent globals are ever merged (the “one definition rule” — “ODR”). Such languages can use the linkonce_odr and weak_odr linkage types to indicate that the global will only be merged with equivalent globals. These linkage types are otherwise the same as their non-odr versions.

Not sure if it's a misuse

[zlojvavan]

@Yvan-xy well, removing inline in header function definition is not an option if header is included in many files