[email-rotation] use list/dict instead of typing; NFCI#3
Merged
gburgessiv merged 1 commit intomainfrom Sep 10, 2025
Merged
Conversation
Direct use of `list`/`dict` is preferred, and something I learned about when I'd half-written this. Didn't realize I left these instances initially.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes type annotations by replacing typing.Dict and typing.List with the built-in dict and list types, which are preferred in Python 3.9+. The change simplifies imports and aligns with current Python typing best practices.
- Removed
DictandListimports from thetypingmodule - Updated all type annotations to use lowercase
dictandlistinstead of theirtypingcounterparts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
(I assume postcommit review policies apply here, and this is really trivial + the tests pass, so...) |
Contributor
|
looks fine to me, consider this postcommit reviewed :) (But I'm not a python expert, I'm trusting you and copilot that it's better not to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct use of
list/dictis preferred, and something I learned about when I'd half-written this. Didn't realize I left these instances initially.