[HIP] rough way of adding cuda_wrapper tests from Externals/CUDA #243
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not happy with this. Ideally, we could put CUDA and HIP common tests together. This is a first step to get some initial feedback (and see what the validation has to say about it). |
jmmartinez
force-pushed
the
cuda_wrappers/hip
branch
from
1849bc4 to
4c88c3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to adapt in a pretty rough way some tests from
Externals/CUDAthat test interactions withcuda_wrapperheaders.This catch the bug fixed by llvm/llvm-project#139697