[flang][tests] Disable Fortran/gfortran/regression/finalize_38.f90#277
Open
[flang][tests] Disable Fortran/gfortran/regression/finalize_38.f90#277
Conversation
| norm2_3.f90 | ||
| pr96711.f90 | ||
|
|
||
| # pmk? |
Contributor
There was a problem hiding this comment.
This test was not in the description?
tarunprabhu
reviewed
Aug 15, 2025
| use_rename_8.f90 | ||
|
|
||
| # The "stop 171" case expects an incorrect number of finalizations. | ||
| finalize_38.f90 |
Contributor
There was a problem hiding this comment.
From the description of the PR, it sounds like this test will never pass with flang because, gfortran's finalization behavior is different from flang's. If this is the case, it may be better to move this to the UNSUPPORTED_FILES list above.
One test case in finalize_38.f90 expects that an allocatable component of an expression result will not be finalized. The flang-new compiler is being updated by the pull request llvm/llvm-project#153509 to ensure finalization of allocatables when they are deallocated, since this is an event that triggers finalization (F'2023 7.5.6.3p2) on a finalizable (3.71) data entity (3.41).
eugeneepshteyn
approved these changes
Aug 15, 2025
tarunprabhu
approved these changes
Aug 15, 2025
Contributor
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
Thanks for the change.
Contributor
|
@klausler, I think this can be merged. Is there anything holding it up? |
Contributor
Author
|
It's not clear whether the corresponding compiler change to flang-new will be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test case in finalize_38.f90 expects that an allocatable component of an expression result will not be finalized. The flang-new compiler is being updated by the pull request
llvm/llvm-project#153509
to ensure finalization of allocatables when they are deallocated, since this is an event that triggers finalization (F'2023 7.5.6.3p2) on a finalizable (3.71) data entity (3.41).