Skip to content

Commit 56faf80

Browse files
[CI] Make US West cluster use SSDs for Windows nodes (#455)
We have seen some decent performance improvements using SSDs for windows nodes particularly in regards to container image pull times (about 30%). This patch parameterizes gke_cluster to enable setting the window_disk_type on one cluster so we can run an A/B test to make sure the expected gains translate to production.
1 parent ac70e3d commit 56faf80

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

premerge/gke_cluster/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ resource "google_container_node_pool" "llvm_premerge_windows" {
9696
"disable-legacy-endpoints" = "true"
9797
}
9898
disk_size_gb = 200
99+
disk_type = var.windows_disk_type
99100
# Terraform wants to recreate the node pool everytime whe running
100101
# terraform apply unless we explicitly set this.
101102
# TODO(boomanaiden154): Look into why terraform is doing this so we do

premerge/gke_cluster/variables.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,9 @@ variable "service_node_pool_locations" {
2323
type = list(any)
2424
default = null
2525
}
26+
27+
variable "windows_disk_type" {
28+
description = "The GCP disk type to use for the windows node boot disks"
29+
type = string
30+
default = "pd-balanced"
31+
}

premerge/main.tf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,10 @@ module "premerge_cluster_us_west" {
6262
linux_machine_type = "n2d-standard-64"
6363
windows_machine_type = "n2d-standard-32"
6464
service_node_pool_locations = ["us-west1-a"]
65+
# TODO(boomanaiden154): Remove this once the experiment is over, either
66+
# reverting to how everything was before or making this the default within
67+
# the gke_cluster module.
68+
windows_disk_type = "pd-ssd"
6569
}
6670

6771
provider "helm" {

0 commit comments

Comments
 (0)