Fix : Add timeout parameters to all HTTP requests#686
Open
justynigam wants to merge 1 commit intollvm:mainfrom
Open
Fix : Add timeout parameters to all HTTP requests#686justynigam wants to merge 1 commit intollvm:mainfrom
justynigam wants to merge 1 commit intollvm:mainfrom
Conversation
Added timeout parameters to prevent indefinite hangs when remote servers become unresponsive. This improves reliability and prevents resource exhaustion in CI/CD pipelines. Changes: - submit-debuginfo-statistics-to-lnt.py: Added 30s timeout to POST requests - submit-lldb-statistics-to-lnt.py: Added 30s timeout to POST requests - process_llvm_commits.py: Added 30s timeout to GitHub GraphQL API calls - build.py: Added 60s timeout to artifact downloads - gcs.py: Added 300s timeout for large compiler binary downloads This fix addresses the issue where HTTP requests without timeouts could hang indefinitely, causing build/CI failures and resource exhaustion.
There was a problem hiding this comment.
Pull request overview
This PR adds timeout parameters to all HTTP requests across the codebase to prevent indefinite hangs during network operations.
- Added appropriate timeout values based on operation type: 30s for API submissions, 60s for standard downloads, and 300s for large compiler downloads
- Modified 5 files with HTTP requests that previously lacked timeout parameters
- All changes maintain existing functionality while improving reliability
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| zorg/jenkins/jobs/util/submit-lldb-statistics-to-lnt.py | Added 30-second timeout to LNT statistics submission requests |
| zorg/jenkins/jobs/util/submit-debuginfo-statistics-to-lnt.py | Added 30-second timeout to debug info statistics submission requests |
| zorg/jenkins/build.py | Added 60-second timeout to HTTP download function |
| premerge/ops-container/process_llvm_commits.py | Added 30-second timeout to GitHub GraphQL API queries |
| llvmbisect/llvmlab/gcs.py | Added 300-second (5 minute) timeout for large compiler downloads with explanatory comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This seems reasonable to me, but I'd like a second opinion on that. |
boomanaiden154
requested changes
Jan 5, 2026
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Is this the result of timeouts actually occurring on the zorg infrastructure?
This does not look like it has been adequately tested, and in absence of actual timesout being observed, I'm hesitant we should move forward with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added timeout parameters to all HTTP requests to prevent indefinite hangs.
Changes
Files
Testing
✅ Syntax validation passed
✅ Timeout parameters verified
✅ Behavior testing passed