Add test for ByteAddressBuffer
#66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekota
changed the title
[RW]ByteAddressBuffer Load* and Store* operationsByteAddressBuffer
inbelic
reviewed
Apr 7, 2025
Contributor
inbelic
left a comment
inbelic
left a comment
There was a problem hiding this comment.
LGTM, although I agree that we could move this to the pr with the implementation changes as well.
Also, can we add duplicate tests with different bit-width types (uint16, and hex8)? That way we test all the different code paths in getRawDXFormat
|
|
||
| // This test checks that we will get the expected values from invoking | ||
| // various `Load*` and `Store` methods on `[RW]ByteAddressBuffer`. | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| // The expected behaviour is to copy over the values in `In` at the given byte-offset | |
| // to their respective offset in `Out`. We expect each load and store to only access | |
| // mapped tiles in a tile resource, so `CheckAccessFullyMapped` should always return | |
| // `true = 1`. | |
Member
Author
Turns out 16-bit and 8-bit values are not supported for raw buffers! |
hekota
added a commit
to hekota/offload-test-suite
that referenced
this pull request
Apr 7, 2025
… input. Remove 8-bit & 16-bit input option because raw buffers can only have R32_TYPELESS DXC type.
Member
Author
|
Merged into #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #65
Closes llvm/wg-hlsl#201