Skip to content

Use Gis flag for asin tests #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spall merged 4 commits into from
Jan 23, 2026
+22 −6
Merged

Use Gis flag for asin tests #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17192fc
use gis flag
spall Jan 21, 2026
fd19dd5
xfail intel machine
spall Jan 21, 2026
ce5dd06
xfail on amd vulkan clang
spall Jan 22, 2026
567688c
fix xfails
spall Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions test/Feature/HLSLLib/asin.16.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,18 @@ DescriptorSets:
...
#--- end

# Bug https://github.com/llvm/offload-test-suite/issues/578
# XFAIL: AMD && Vulkan
# Bug: Looks like it might be a driver bug but the gpu is out of support
# so we will not investigate this.
# only fails with DXC so once Gis spirv support is added to Clang I suspect it will
# fail with clang as well.
# XFAIL: Intel && Vulkan && DXC

# Unimplemented: support for the Gis flag generating the
# SignedZeroInfNanPreserve capability needs to be added to clang
# https://github.com/llvm/llvm-project/issues/177497
# XFAIL: AMD && Vulkan && Clang

# REQUIRES: Half
# RUN: split-file %s %t
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Gis -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o
14 changes: 11 additions & 3 deletions test/Feature/HLSLLib/asin.32.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,17 @@ DescriptorSets:
...
#--- end

# Bug https://github.com/llvm/offload-test-suite/issues/578
# XFAIL: AMD && Vulkan
# Bug: Looks like it might be a driver bug but the gpu is out of support
# so we will not investigate this.
# only fails with DXC so once Gis spirv support is added to Clang I suspect it will
# fail with clang as well.
# XFAIL: Intel && Vulkan && DXC

# Unimplemented: support for the Gis flag generating the
# SignedZeroInfNanPreserve capability needs to be added to clang
# https://github.com/llvm/llvm-project/issues/177497
# XFAIL: AMD && Vulkan && Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %dxc_target -T cs_6_5 -Gis -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o
Loading