Fix multiple test failures #677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
farzonl
commented
Jan 28, 2026
farzonl
commented
- Fix tests missing 16 bit requires
- Fix Missing XFAILS for older AMD GPUs that were just called Radeon
farzonl
commented
Jan 28, 2026
test/lit.cfg.py
Outdated
| config.available_features.add("NV") | ||
| if "AMD" in device["Description"]: | ||
| if ("AMD" in device["Description"] or | ||
| "Radeon" in device["Description"]): |
Member
Author
There was a problem hiding this comment.
One of the AMD GPUs I test with via egpu Has a device name of Radeon RX 580 Series. without this change the XFAILS for AMD are never applied and we get over 10 extra unnecessary test failures.
- Fix tests missing 16 bit requires - Fix Missing XFAILS for older AMD GPUs that were just called Radeon
spall
reviewed
Jan 28, 2026
test/WaveOps/WaveActiveMax.fp16.test
Outdated
| # Bug https://github.com/llvm/offload-test-suite/issues/393 | ||
| # XFAIL: Metal | ||
|
|
||
| # REQUIRES: Float16 |
Collaborator
There was a problem hiding this comment.
is this the same as saying Requires Half? that is what the other tests do i think?
farzonl
commented
Jan 28, 2026
bob80905
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.