[TorchToTosa] add conv reshape in core lowering#4494
Open
[TorchToTosa] add conv reshape in core lowering#4494
Conversation
Contributor
Author
- Insert rank-4/5 reshapes for conv inputs/weights during TorchToTosa lowering Signed-off-by: Cathal Corbett <cathal.corbett@arm.com> Change-Id: Ica1b5cc265822ecd054f832908ec31bc2325c661
Change-Id: I5c0c1a5ae2d90cee500dc76247f5952b99bb48f9 Signed-off-by: Cathal Corbett <cathal.corbett@arm.com>
sahas3
reviewed
Mar 11, 2026
Change-Id: I55752f920f8ad170b3d35c0c8bf5f8b94c4d9de0 Signed-off-by: Cathal Corbett <cathal.corbett@arm.com>
Lallapallooza
requested changes
Mar 12, 2026
| if (tmplIt == argToTemplates.end()) | ||
| return failure(); | ||
|
|
||
| const RankTemplate *match = nullptr; |
Member
There was a problem hiding this comment.
Template matching is rank-only and first-hit. If multiple reshape templates exist for the same argument/rank, the selected template can be wrong, causing incorrect reshapes and semantic drift.
Change-Id: I9c67bbbb030511a72ec8f4c59b3498ba4dfdb0fc Signed-off-by: Cathal Corbett <cathal.corbett@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ica1b5cc265822ecd054f832908ec31bc2325c661