[TorchToStableHLO] Support bitwise_or.Scalar and bitwise_xor.Scalar l…#4496
Open
BruceXinXin wants to merge 1 commit intollvm:mainfrom
Open
[TorchToStableHLO] Support bitwise_or.Scalar and bitwise_xor.Scalar l…#4496BruceXinXin wants to merge 1 commit intollvm:mainfrom
BruceXinXin wants to merge 1 commit intollvm:mainfrom
Conversation
…owerings Add Torch dialect op definitions for aten::bitwise_or.Scalar and aten::bitwise_xor.Scalar (along with their inplace variants), and lower them to StableHLO via chlo::BroadcastOrOp and chlo::BroadcastXorOp respectively. This reuses the existing ConvertAtenLogicalBinaryOp template which already handles scalar-to-tensor promotion and broadcasting, matching the pattern used by bitwise_and.Scalar.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[TorchToStableHLO] Support bitwise_or.Scalar and bitwise_xor.Scalar lowerings
Summary
The Scalar variants of
bitwise_orandbitwise_xorwere missing fromboth the Torch dialect and the StableHLO conversion. The Tensor variants
existed, and
bitwise_and.Scalarwas already supported, butorandxorwith scalar operands were not handled.