[Torch] Add aten.add.float op with folding and lowering to arith#4500
Open
BruceXinXin wants to merge 1 commit intollvm:mainfrom
Open
[Torch] Add aten.add.float op with folding and lowering to arith#4500BruceXinXin wants to merge 1 commit intollvm:mainfrom
BruceXinXin wants to merge 1 commit intollvm:mainfrom
Conversation
Register the `aten::add.float : (float, float) -> (float)` op in the Torch dialect. Implement constant folding via `atenBinaryFloatOperatorFoldHelper` and lower to `arith.addf` in the TorchToArith conversion.
Author
|
Hi @sjarus, I don't have permission to add reviewer. Do you know who is the best person I can request for review? Thanks you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
aten.add.floatopThis PR adds support for the
aten::add.float : (float, float) -> (float)operator, complementing the existingaten.sub.floatandaten.mul.floatops.Changes
GeneratedTorchOps.td): NewTorch_AtenAddFloatOpwith twoTorch_FloatTypeoperands, custom assembly format, and folder support.TorchOps.cpp):AtenAddFloatOp::foldusingatenBinaryFloatOperatorFoldHelperwitha + b.TorchToArith.cpp): MapsAtenAddFloatOptoarith::AddFOpviaConvertAtenBinaryOp, and marks it illegal on the conversion target.torch_ods_gen.py): Addedaten::add.floatemit entry withhas_folder=True.