[TorchToStablehlo] Add lowering for prims.xor_sum to stablehlo.reduce…#4501
Draft
BruceXinXin wants to merge 1 commit intollvm:mainfrom
Draft
[TorchToStablehlo] Add lowering for prims.xor_sum to stablehlo.reduce…#4501BruceXinXin wants to merge 1 commit intollvm:mainfrom
BruceXinXin wants to merge 1 commit intollvm:mainfrom
Conversation
… with XOR Add support for lowering `prims::xor_sum` to StableHLO's `stablehlo.reduce` using `stablehlo.xor` as the reduction body. The op reduces integer tensors along specified dimensions using bitwise XOR, with an initial value of zero. - Define `PrimsXorSumOp` in GeneratedTorchOps.td via torch_ods_gen.py - Implement `ConvertAtenReductionOp<PrimsXorSumOp>` in Reduction.cpp - Register the pattern in `populateReductionOpPatternsAndLegality` - Add lit test for the new lowering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[TorchToStablehlo] Add
prims.xor_sum→stablehlo.reduceloweringSummary
Adds end-to-end support for lowering
prims::xor_sumto StableHLO.Changes
prims::xor_sum : (Tensor, int[]?, int?) -> (Tensor).Torch_PrimsXorSumOpdefinition (auto-generated).PrimsXorSumOpto the zero-init branch increateInitialValueForReduceOp.stablehlo::XorOpcase increateReduceOpWithSingleRegionOp.ConvertAtenReductionOp<PrimsXorSumOp>::matchAndRewritewithdimension normalization and integer type validation.
INSERT_ATEN_REDUCTION_OP_PATTERN.torch.prims.xor_sumonsi32.Test