[SPIR-V] Representing SpirvType in Clang's Type System#181
Open
cassiebeckley wants to merge 2 commits intollvm:mainfrom
Open
[SPIR-V] Representing SpirvType in Clang's Type System#181cassiebeckley wants to merge 2 commits intollvm:mainfrom
cassiebeckley wants to merge 2 commits intollvm:mainfrom
Conversation
This describes an approach to representing `SpirvType` in Clang.
Keenuts
reviewed
Feb 24, 2025
s-perron
reviewed
Feb 24, 2025
s-perron
approved these changes
Feb 27, 2025
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
This seems reasonable to me.
Keenuts
approved these changes
Feb 28, 2025
cassiebeckley
added a commit
to cassiebeckley/llvm-project
that referenced
this pull request
Apr 2, 2025
This implements the design proposed by [Representing SpirvType in Clang's Type System](llvm/wg-hlsl#181). It creates `HLSLInlineSpirvType` as a new `Type` subclass, and `__hlsl_spirv_type` as a new builtin type template to create such a type. This new type is lowered to the `spirv.Type` target extension type, as described in [Target Extension Types for Inline SPIR-V and Decorated Types](https://github.com/llvm/wg-hlsl/blob/main/proposals/0017-inline-spirv-and-decorated-types.md).
cassiebeckley
added a commit
to llvm/llvm-project
that referenced
this pull request
May 27, 2025
This implements the design proposed by [Representing SpirvType in Clang's Type System](llvm/wg-hlsl#181). It creates `HLSLInlineSpirvType` as a new `Type` subclass, and `__hlsl_spirv_type` as a new builtin type template to create such a type. This new type is lowered to the `spirv.Type` target extension type, as described in [Target Extension Types for Inline SPIR-V and Decorated Types](https://github.com/llvm/wg-hlsl/blob/main/proposals/0017-inline-spirv-and-decorated-types.md).
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 27, 2025
This implements the design proposed by [Representing SpirvType in Clang's Type System](llvm/wg-hlsl#181). It creates `HLSLInlineSpirvType` as a new `Type` subclass, and `__hlsl_spirv_type` as a new builtin type template to create such a type. This new type is lowered to the `spirv.Type` target extension type, as described in [Target Extension Types for Inline SPIR-V and Decorated Types](https://github.com/llvm/wg-hlsl/blob/main/proposals/0017-inline-spirv-and-decorated-types.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This describes an approach to representing
SpirvTypein Clang.