Skip to content

fix: add weights_only=True to torch.load calls in apply_delta.py #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: add weights_only=True to torch.load calls in apply_delta.py #3863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fastchat/model/apply_delta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def split_files(model_path, tmp_path, split_size):
part = 0
try:
for file_path in tqdm(files):
state_dict = torch.load(file_path)
state_dict = torch.load(file_path, weights_only=True)
new_state_dict = {}

current_size = 0
Expand Down Expand Up @@ -87,19 +87,19 @@ def apply_delta_low_cpu_mem(base_model_path, target_model_path, delta_path):
base_files = glob.glob(base_pattern)
delta_pattern = os.path.join(tmp_delta_path, "pytorch_model-*.bin")
delta_files = glob.glob(delta_pattern)
delta_state_dict = torch.load(delta_files[0])
delta_state_dict = torch.load(delta_files[0], weights_only=True)

print("Applying the delta")
weight_map = {}
total_size = 0

for i, base_file in tqdm(enumerate(base_files)):
state_dict = torch.load(base_file)
state_dict = torch.load(base_file, weights_only=True)
file_name = f"pytorch_model-{i}.bin"
for name, param in state_dict.items():
if name not in delta_state_dict:
for delta_file in delta_files:
delta_state_dict = torch.load(delta_file)
delta_state_dict = torch.load(delta_file, weights_only=True)
gc.collect()
if name in delta_state_dict:
break
Expand Down
Loading